Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylc review show any *.cylc file with synatax highlighting #4444

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Cylc review show any *.cylc file with synatax highlighting #4444

merged 1 commit into from
Oct 4, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 1, 2021

This is a small change with no associated Issue.

RE: Cylc 7 Review: Make any file ending in .cylc appear highlighted as a .cylc file. flow-processed.cylc and <timestamp>-start.cylc were not previously highlighted.

V. small change on legacy system hence 1 reviewer only.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Does not need tests (small manually testable change to legacy system).
  • No change log entry required (change will only affect Cylc8 beta users).
  • No documentation update required.

@wxtim wxtim requested a review from MetRonnie October 1, 2021 10:47
@wxtim wxtim self-assigned this Oct 1, 2021
@wxtim wxtim added this to the cylc-7.8.x milestone Oct 1, 2021
@wxtim wxtim added could be better Not exactly a bug, but not ideal. small labels Oct 1, 2021
MetRonnie
MetRonnie approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And note that flow.cylc.processed is no longer a thing)

@MetRonnie MetRonnie merged commit 5ef4419 into cylc:7.8.x Oct 4, 2021
@wxtim wxtim deleted the cylc_review_show_any_.cylc_file_with_synatax_highlighting branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-7.9.6 and 7.8.11
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @MetRonnie @hjoliver