Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc clean: remove top level dir when no run dirs left #5033

Merged
merged 3 commits into from
Aug 3, 2022
Merged

cylc clean: remove top level dir when no run dirs left #5033

merged 3 commits into from
Aug 3, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 2, 2022 •
edited
Loading

These changes close #4963

When cleaning all runs or the last remaining run in a workflow dir, cylc clean will now also remove the _cylc-install and top level directory, if it is empty.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.
  • [if bugfix] PRs raised to both master and the relevant bugfix branch. Merge 8.0.x into master #5041

@MetRonnie MetRonnie added the could be better Not exactly a bug, but not ideal. label Aug 2, 2022
@MetRonnie MetRonnie added this to the cylc-8.0.1 milestone Aug 2, 2022
@MetRonnie MetRonnie self-assigned this Aug 2, 2022
@oliver-sanders oliver-sanders changed the base branch from master to 8.0.x August 2, 2022 09:22
hjoliver
hjoliver approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested as working 👍

@MetRonnie MetRonnie deleted the branch cylc:8.0.x August 3, 2022 11:58
@MetRonnie MetRonnie closed this Aug 3, 2022
@MetRonnie MetRonnie reopened this Aug 3, 2022
@MetRonnie
Copy link
Member Author

Merging with 2 approvals

@MetRonnie MetRonnie merged commit d175949 into cylc:8.0.x Aug 3, 2022
@MetRonnie MetRonnie deleted the cylc-clean branch August 3, 2022 14:41
@MetRonnie MetRonnie mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Milestone
cylc-8.0.1
Development

Successfully merging this pull request may close these issues.

Top level dir not removed when cleaning all runs
3 participants
@MetRonnie @hjoliver @oliver-sanders