Lint.hardcode style index numbers #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wxtim
force-pushed
the
lint.hardcode_style_index_numbers
branch
2 times, most recently
from
1e48ca0
to
a6f71d7
Compare
…drift in future Added an --ignore/-n command to exclude style rules. added testing for ignore
wxtim
force-pushed
the
lint.hardcode_style_index_numbers
branch
from
a6f71d7
to
42269b5
Compare
MetRonnie
approved these changes
Aug 15, 2022
MetRonnie
reviewed
Aug 15, 2022
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
Artifact upload failure is unrelated. Merging with two approvals. |
hjoliver
pushed a commit
to hjoliver/cylc-flow
that referenced
this pull request
Aug 18, 2022
* Hardcoded error numbers for the style checks to prevent error number drift in future Added an --ignore/-n command to exclude style rules. added testing for ignore * Update cylc/flow/scripts/lint.py Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Aug 18, 2022
* master: tui: add poll mutation (cylc#5075) bump dev version Add workflow field to ClientError, ClientTimeout Bump dev version Lint.hardcode style index numbers (cylc#5055) Wait for preparing tasks to submit before auto restart (cylc#5062) update changelog Prepare release 8.0.1 scan: ignore FileNotFoundError (cylc#5065)
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Aug 26, 2022
* Hardcoded error numbers for the style checks to prevent error number drift in future Added an --ignore/-n command to exclude style rules. added testing for ignore * Update cylc/flow/scripts/lint.py Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Oct 3, 2022
* Hardcoded error numbers for the style checks to prevent error number drift in future Added an --ignore/-n command to exclude style rules. added testing for ignore * Update cylc/flow/scripts/lint.py Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5052 -
--ignoreor-n.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users