Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc vip #5121

Merged
merged 7 commits into from
Nov 17, 2022
Merged

cylc vip #5121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58228c6
cylc vip
wxtim Sep 7, 2022
db21b94
remove unwanted constants
wxtim Nov 15, 2022
cf8fd82
VIP uses correct install interface
wxtim Nov 15, 2022
6bcbf66
minor fix
wxtim Nov 15, 2022
fe4597b
response to review;pruned unwanted code;made test check implicit install
wxtim Nov 17, 2022
5e81153
Update cylc/flow/option_parsers.py
wxtim Nov 17, 2022
48fc3ac
add workflow_id to sysargv for play step if it isn't there
wxtim Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
VIP uses correct install interface
  • Loading branch information
@wxtim
wxtim committed Nov 15, 2022
commit cf8fd826acb0b9280a1727b010b2f83210d872e4
3 changes: 2 additions & 1 deletion cylc/flow/scripts/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,13 @@ def main(
def install_cli(
opts: 'Values',
reg: Optional[str] = None
) -> None:
) -> str:
"""Install workflow and scan for already-running instances."""
wf_name = install(opts, reg)
asyncio.run(
scan(wf_name, not opts.no_ping)
)
return wf_name


def install(
Expand Down
6 changes: 3 additions & 3 deletions cylc/flow/scripts/validate_install_play.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
wrapped_main as validate_main
)
from cylc.flow.scripts.install import (
INSTALL_OPTIONS, install, get_source_location
INSTALL_OPTIONS, install_cli as cylc_install, get_source_location
)
from cylc.flow.scheduler_cli import PLAY_OPTIONS
from cylc.flow.option_parsers import (
Expand Down Expand Up @@ -91,8 +91,8 @@ def main(parser: COP, options: 'Values', workflow_id: Optional[str] = None):
log_subcommand('validate', source)
validate_main(parser, options, str(source))

log_subcommand('install', '.')
workflow_id = install(options, workflow_id)
log_subcommand('install', source)
workflow_id = cylc_install(options, workflow_id)

cleanup_sysargv(
'play',
Expand Down