reinstall changes to rose-suite.conf
#5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
from
10c14ba
to
5cd1922
Compare
7 tasks
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
2 times, most recently
from
639e2b5
to
294bfc7
Compare
wxtim
changed the title
rose-suite.conf
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
from
8228467
to
c51fbd1
Compare
|
Couple of small comments, otherwise LGTM, tested as working. |
datamel
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Tested as working. A couple of observations which may be irrelevant...
- upon reinstalling a workflow that has had no changes, it thinks the
rose-suite.confhas changed. This is due to the difference in the added# Config Options ' (cylc-install)' from CLI appended to options already inrose-suite.conf.. opts=(cylc-install)). Also, do we need to adapt this to note that it is reinstall rather than install? - Cylc (re)install does not copy a nested
rose-suite.conffile. I don't think this is an issue for now, since support for sub-workflows is limited (I believe best practice has not been agreed), although this may need consideration in the future.
ATM there is no support for nesting so this is ok. |
MetRonnie
reviewed
Sep 13, 2022
CHANGES.md
Outdated
Comment on lines
51
to
53
| [#5125](https://github.com/cylc/cylc-flow/pull/5125) - Allow rose-suite.conf | ||
| changes to be considered by ``cylc reinstall``. | ||
|
|
|
@wxtim could you rebase onto 8.0.x and fix the changelog. |
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
from
45ab9b7
to
105d3c7
Compare
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
from
105d3c7
to
45ab9b7
Compare
wxtim
force-pushed
the
fix.rose-re-install-failure
branch
from
45ab9b7
to
5230253
Compare
oliver-sanders
approved these changes
Oct 5, 2022
wxtim
added a commit
that referenced
this pull request
Oct 6, 2022
* fix reversed data-store edge source-target (#5156) Co-authored-by: David Sutherland <davidwollow@gmail.com> * `log_vc_info`: Redirect diff straight to file to avoid blocking pipe (#5139) * log_vc_info: redirect diff straight to file to avoid blocking pipe * Update changelog * A no-flow task should not merge and retrigger incomplete children (#5146) Prevent no-flow merge. * remote-install: add "ana/" to the default install list (#5137) * The `ana/` directory is used by `rose_ana` to load comparison modules. * These are typically run where the data is generated which is often remote. * These directories typically contain a small number of Python files. * Auto bump dev version on release * Run GH Actions tests on push to `8.*.x` branches * Db store force triggered (#5023) Store force-triggered flag in the run DB. * Add a new functional test. * Remove some redundant DB updates. * Update change log. * remote: ensure all remote commands use a platform config (#5152) Remote interfaces (SSH & rsync) now all require a platform object for configuration purposes (e.g. "ssh command"). Convenience interfaces added for remote calls to Cylc servers which use the localhost platform configuration. These are now used for: * `cylc play` command re-invocation on a Cylc server. * Evaluation of host selection rankings (via `cylc psutil`). * The detect old contact file check, which tests whether a workflow is still running on the server recored in the contact file. * host select: allow unary operators in ranking expressions (#5151) * host select: allow unary operators in ranking expressions * Whitelist unary operators (required for expressions like `-1 * x`) in `[scheduler][run hosts]ranking` expressions. * Improve error formatting. * Update tests/unit/test_exceptions.py Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> * reinstall changes to `rose-suite.conf` (#5125) reinstall: ensure rose-suite.conf changes trigger reinstallation Co-authored-by: David Sutherland <davidwollow@gmail.com> Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com> Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
datamel
pushed a commit
to datamel/cylc-flow
that referenced
this pull request
Oct 19, 2022
* fix reversed data-store edge source-target (cylc#5156) Co-authored-by: David Sutherland <davidwollow@gmail.com> * `log_vc_info`: Redirect diff straight to file to avoid blocking pipe (cylc#5139) * log_vc_info: redirect diff straight to file to avoid blocking pipe * Update changelog * A no-flow task should not merge and retrigger incomplete children (cylc#5146) Prevent no-flow merge. * remote-install: add "ana/" to the default install list (cylc#5137) * The `ana/` directory is used by `rose_ana` to load comparison modules. * These are typically run where the data is generated which is often remote. * These directories typically contain a small number of Python files. * Auto bump dev version on release * Run GH Actions tests on push to `8.*.x` branches * Db store force triggered (cylc#5023) Store force-triggered flag in the run DB. * Add a new functional test. * Remove some redundant DB updates. * Update change log. * remote: ensure all remote commands use a platform config (cylc#5152) Remote interfaces (SSH & rsync) now all require a platform object for configuration purposes (e.g. "ssh command"). Convenience interfaces added for remote calls to Cylc servers which use the localhost platform configuration. These are now used for: * `cylc play` command re-invocation on a Cylc server. * Evaluation of host selection rankings (via `cylc psutil`). * The detect old contact file check, which tests whether a workflow is still running on the server recored in the contact file. * host select: allow unary operators in ranking expressions (cylc#5151) * host select: allow unary operators in ranking expressions * Whitelist unary operators (required for expressions like `-1 * x`) in `[scheduler][run hosts]ranking` expressions. * Improve error formatting. * Update tests/unit/test_exceptions.py Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> * reinstall changes to `rose-suite.conf` (cylc#5125) reinstall: ensure rose-suite.conf changes trigger reinstallation Co-authored-by: David Sutherland <davidwollow@gmail.com> Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com> Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two separate, but related bugs (one of which was partially protecting us from the other, except when using rose stem):
1. Rsync Output
cylc reinstallrelied on the rsync stdout being empty to choose not to reinstall. Under some circumstances messages such ascannot delete dirctory: optwere causing re-installations unnecessarily.2.
rose-suite.confreinstallationUnder many circumstances the first bug was allowing re-installation to be triggered when only the
rose-suite.confhad changed, despiterose-suite.confbeing on the list of files excluded from the rsync.With the first bug fixed users could change the source
rose-suite.confand have Cylc tell them that nothing required re-installing.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.rose-suite.conf[tests] cylc-rose#178CHANGES.mdentry included if this is a change that can affect users