Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow_state xtrigger: infer run number #5131

Merged
merged 3 commits into from
Sep 14, 2022
Merged

workflow_state xtrigger: infer run number #5131

merged 3 commits into from
Sep 14, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Sep 13, 2022 •
edited
Loading

Closes #5126

Infer the run number if not specified in the workflow_state xtrigger

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs update needed
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@MetRonnie MetRonnie added this to the cylc-8.0.3 milestone Sep 13, 2022
@MetRonnie MetRonnie self-assigned this Sep 13, 2022
@MetRonnie MetRonnie linked an issue Sep 13, 2022 that may be closed by this pull request
workflow_state: infer run number #5126
Closed
oliver-sanders
oliver-sanders approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers.

hjoliver
hjoliver approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@hjoliver hjoliver merged commit e62bc92 into cylc:8.0.x Sep 14, 2022
@MetRonnie MetRonnie deleted the workflow_state branch September 14, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@datamel datamel Awaiting requested review from datamel

Assignees

@MetRonnie MetRonnie

Labels
small
Projects
None yet
Milestone
cylc-8.0.3
Development

Successfully merging this pull request may close these issues.

workflow_state: infer run number
3 participants
@MetRonnie @hjoliver @oliver-sanders