Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A no-flow task should not merge and retrigger incomplete children #5146

Merged
merged 3 commits into from
Sep 26, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
New func test.
  • Loading branch information
hjoliver committed Sep 20, 2022
commit 4f0a8d17f5510c8fcfd3cbcc2171e0a8313b43d8
47 changes: 47 additions & 0 deletions tests/functional/flow-triggers/13-noflow-nomerge.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
#!/usr/bin/env bash
# THIS FILE IS PART OF THE CYLC WORKFLOW ENGINE.
# Copyright (C) NIWA & British Crown (Met Office) & Contributors.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#-------------------------------------------------------------------------------

. "$(dirname "$0")/test_header"
set_test_number 7

install_workflow "${TEST_NAME_BASE}" "${TEST_NAME_BASE}"
DB="${WORKFLOW_RUN_DIR}/log/db"

run_ok "${TEST_NAME_BASE}-validate" cylc validate "${WORKFLOW_NAME}"
run_ok "${TEST_NAME_BASE}-run" cylc play "${WORKFLOW_NAME}"
poll_grep_workflow_log "Workflow stalled"

run_ok "${TEST_NAME_BASE}-trigger" cylc trigger --flow=none "${WORKFLOW_NAME}//1/a"
poll_grep_workflow_log -E "1/a running job:02 flows:none.*=> succeeded"

cylc stop --now --now --max-polls=5 --interval=2 "$WORKFLOW_NAME"

TEST_NAME="${TEST_NAME_BASE}-count"
QUERY="SELECT COUNT(*) FROM task_states WHERE name=='a'"
run_ok "${TEST_NAME}" sqlite3 "${DB}" "$QUERY"
cmp_ok "${TEST_NAME}.stdout" <<__END__
2
__END__

QUERY="SELECT COUNT(*) FROM task_states WHERE name=='b'"
run_ok "${TEST_NAME}" sqlite3 "${DB}" "$QUERY"
cmp_ok "${TEST_NAME}.stdout" <<__END__
1
__END__

purge
7 changes: 7 additions & 0 deletions tests/functional/flow-triggers/13-noflow-nomerge/flow.cylc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[scheduling]
[[graph]]
R1 = "a => b"
[runtime]
[[a]]
[[b]]
script = false # die as incomplete