Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db upgrade 8.0.3 #5187

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Db upgrade 8.0.3 #5187

merged 11 commits into from
Oct 12, 2022

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Oct 10, 2022 •
edited
Loading

Follow-up #5023
Supersede #5173

Automatically upgrade pre-8.0.3 DBs (at restart) by adding the new task_states "is_manual_submit" column.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@hjoliver hjoliver added the bug Something is wrong :( label Oct 10, 2022
@hjoliver hjoliver added this to the cylc-8.0.3 milestone Oct 10, 2022
@hjoliver hjoliver self-assigned this Oct 10, 2022
@hjoliver
Copy link
Member Author

Integration test added.

@MetRonnie
Use context manager for get_pri_dao()
e6d06e5 
In order to ensure it is closed after use
@MetRonnie
Fix tests
0087112
@MetRonnie
Fix restart incompat version
596f595 
It turns out there was a change to the DB structure in cylc#4739 (8.0rc3).
The restart incompat version should have been bumped but this was missed.
MetRonnie
MetRonnie requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened a PR against this with some fixes, including ensuring the DAO is closed: hjoliver#26

MetRonnie
MetRonnie approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working

CHANGES.md Outdated Show resolved Hide resolved
@hjoliver @MetRonnie
Update CHANGES.md [skip ci]
0153153 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@hjoliver
Copy link
Member Author

I don't think we need to bother @oliver-sanders with a re-review (he approved before the tweaks).

@hjoliver hjoliver merged commit f25ac49 into cylc:8.0.x Oct 12, 2022
@hjoliver hjoliver deleted the db-upgrade-803 branch October 12, 2022 00:02
@hjoliver hjoliver mentioned this pull request Oct 12, 2022
Closed
8 tasks
@MetRonnie MetRonnie self-assigned this Oct 12, 2022
@MetRonnie MetRonnie mentioned this pull request Oct 12, 2022
Closed
@oliver-sanders oliver-sanders mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@hjoliver hjoliver

@MetRonnie MetRonnie

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoliver @oliver-sanders @MetRonnie