DB interface & safety improvements #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not create tables by default, only if specified via kwarg - Provide context manager functionality to automatically close DB connection - A WorkflowDatabaseManager should only be created by Scheduler; just use CylcWorkflowDAO elsewhere
wxtim
reviewed
Jan 26, 2023
wxtim
approved these changes
Jan 26, 2023
|
(Test failure is just linkcheck) |
hjoliver
reviewed
Jan 26, 2023
| if db_file.exists(): | ||
| dao = CylcWorkflowDAO(db_file, is_public=False) |
There was a problem hiding this comment.
Huh, scan was reading private DBs in spite of the comment above? 😬
There was a problem hiding this comment.
It was reading the private DB until b338a91 when the comment was added. But the is_public arg of CylcWorkflowDAO() was not updated in that PR
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses same issue as #5313
WorkflowDatabaseManagershould only be created byScheduler; just useCylcWorkflowDAOelsewhere, or certain static methods onWorkflowDatabaseManagerCheck List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.?.?.xbranch.