Cylc lint fixes #5363
Merged
Cylc lint fixes #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified original Regex to test for _any_ letter being lowercase - Added regex for FAMILY:trigger-all and trigger-any
|
Check tick boxes in #4917 on merge. |
MetRonnie
reviewed
Feb 13, 2023
|
Thanks for spotting the issues with those regexes @MetRonnie |
I'm not seeing any new commits. Still need to push changes? |
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Nope - still need to avoid pushing changes which over-ride the comments I enacted using github. :( |
|
This was open against master but on 8.1.2 milestone, I have updated the base branch to 8.1.x |
MetRonnie
reviewed
Feb 14, 2023
MetRonnie
approved these changes
Feb 14, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Feb 17, 2023
…lc into fix_localhost_platform_matching * 'fix_localhost_platform_matching' of github.com:wxtim/cylc: Fix a bug preventing `cylc vip --workflow-name=foo` from working. (cylc#5349) fix no rose vars in cylc view (cylc#5367) Cylc lint fixes (cylc#5363) data store: support unsatisfied ext_trigger fix mypy fail caused by python/mypy#13969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ticket combining a number of small fixes for Cylc lint:
Closes:
rose host-select#5362 - With style check warn user thatplatform = $(some script)is still possible, but platform logic means that it's probably not a great idea. Additionally with 728 check warns that ``host=`some script` ` will break at Cylc 8.FAMILY:trigger-allandtrigger-any.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.