Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduated force-triggering (prereqs, xtriggers, queues). #5585

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Jun 14, 2023

Close #5572 (and extends it to push ext-triggers as well)

  • If a task has unsatisfied prerequisites, cylc trigger will satisfy them
  • Otherwise, it will satisfy any unsatisfied xtriggers
  • Otherwise, it will submit the task to run despite queue limiting

The runahead limit is ignored (i.e., you can trigger tasks beyond the limit).

Reviewers - this is an important part of required intervention capability. E.g. if starting a flow in the middle of a cycle point, we need to be able to set up clock-triggered tasks in subsequent cycles to start checking their clock-triggers now, but not to run immediately.

@dpmatthews - pinging you for a quick look, as the brains behind the xtrigger tweak on this branch.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc](https://github.com/cylc/cylc-doc) pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added this to the cylc-8.2.0 milestone Jun 14, 2023
@hjoliver hjoliver self-assigned this Jun 14, 2023
@hjoliver hjoliver marked this pull request as ready for review June 16, 2023 10:43
@hjoliver
Copy link
Member Author

hjoliver commented Jun 22, 2023

For the record, the way users force-spawn an xtriggered task such that it starts checking its xtrigger now, as opposed to actually running now, really falls into the cylc set proposal discussion. But we need this particularly capability fairly urgently, so temporarily homing it here in cylc trigger would be better than delaying it for long. [Discussed more on #5572]

@MetRonnie MetRonnie modified the milestones: cylc-8.2.0, cylc-8.3.0 Jul 17, 2023
@hjoliver
Copy link
Member Author

(Probably superseded by the newly agreed intervention plans,)

@oliver-sanders oliver-sanders marked this pull request as draft July 17, 2023 10:19
@oliver-sanders
Copy link
Member

Converted to draft to remove this from the review list for now. There may well be bits of this we will want to salvage.

@hjoliver hjoliver removed this from the cylc-8.3.0 milestone Sep 18, 2023
@hjoliver
Copy link
Member Author

Superseded by #5658

(I'll close this once I get a chance to do a quick salvage investigation).

@oliver-sanders
Copy link
Member

@hjoliver, ready to close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spawning parentless clock-xtriggered task
3 participants