Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: prevent no-flow tasks from spawning downstreams in compat mode #5614

Merged
merged 1 commit into from
Jul 13, 2023
Merged

pool: prevent no-flow tasks from spawning downstreams in compat mode #5614

merged 1 commit into from
Jul 13, 2023

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant - skipping 8.1.5

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Jul 4, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Jul 4, 2023
@oliver-sanders oliver-sanders self-assigned this Jul 4, 2023
@oliver-sanders oliver-sanders marked this pull request as draft July 4, 2023 10:11
@oliver-sanders oliver-sanders marked this pull request as ready for review July 11, 2023 12:42
wxtim
wxtim approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read
  • Manually tested

😄

hjoliver
hjoliver approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit 1e7693e into cylc:master Jul 13, 2023
25 checks passed
@oliver-sanders oliver-sanders deleted the 5613 branch July 13, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.2.0
Development

Successfully merging this pull request may close these issues.

flows: no-flow tasks flow on in compatibility mode
3 participants
@oliver-sanders @hjoliver @wxtim