Fix cylc clean remote re-invocation bug
#5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,10 +121,17 @@ def get_option_parser(): | |||
| parser.add_option( | |||
| '--timeout', | |||
| help=("The number of seconds to wait for cleaning to take place on " | |||
| "remote hosts before cancelling."), | |||
| r"remote hosts before cancelling. Default: %default."), | |||
There was a problem hiding this comment.
Nice to document the defaults, I have no idea why optparse does not do this by "default".
We are already defining our own "help formatter", looks like we could override expand_default to add a "Default: %default" bit onto the end of every option where a default is set rather than having to add it to each option manually. (for future work).
There was a problem hiding this comment.
Have you turned this into a new issue?
oliver-sanders
approved these changes
Jul 24, 2023
wxtim
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5628
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.