Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data store: fix incorrect task state #5650

Merged
merged 6 commits into from
Aug 1, 2023
Merged

data store: fix incorrect task state #5650

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ea57a5
revert condition change
wxtim Jul 27, 2023
d631f65
remove unwanted method?
wxtim Aug 1, 2023
9a57fd9
put update data store back only if scheduler has changed
wxtim Aug 1, 2023
2791e5a
move update database
wxtim Aug 1, 2023
f536ec7
Revert "move update database"
wxtim Aug 1, 2023
68ce95b
remove unwanted call
wxtim Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "move update database" 
This reverts commit 2791e5a.
  • Loading branch information
@wxtim
wxtim committed Aug 1, 2023
commit f536ec77e1d6ff0381c6e870f121cb12ee8cde11
4 changes: 2 additions & 2 deletions cylc/flow/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,8 +1775,6 @@ async def main_loop(self) -> None:
with suppress(KeyError):
self.timers[self.EVENT_STALL_TIMEOUT].stop()

# Database update
self.workflow_db_mgr.put_task_pool(self.pool)
self.update_data_store()
wxtim marked this conversation as resolved.
Show resolved Hide resolved

self.process_workflow_db_queue()
Expand Down Expand Up @@ -1861,6 +1859,8 @@ async def update_data_structure(self, reloaded: bool = False):
# Non-async sleep - yield to other threads rather
# than event loop
sleep(0)
# Database update
self.workflow_db_mgr.put_task_pool(self.pool)

def check_workflow_timers(self):
"""Check timers, and abort or run event handlers as configured."""
Expand Down
Loading