Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: exclude mypy with more recent python version #5735

Merged
merged 1 commit into from
Sep 19, 2023
Merged

actions: exclude mypy with more recent python version #5735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
actions: exclude mypy with more recent python version 
* matplotlib has not dropped Python 3.7 support.
* mypy produces a false positive error when scanning the installed
  matplotlib code (even though no_silence_site_packages=false).
* cylc is still compatible with the more recent matplotlib releases,
  it's down to the installer (pip/conda/whatever) to install a
  version that's compatible with the python interpretter
  so there's no reason to put an upper pin in the metadata.
  • Loading branch information
@oliver-sanders
oliver-sanders committed Sep 19, 2023
commit ccde8377d8332fcddd62c9a23e31325bf3a8ddc6
4 changes: 3 additions & 1 deletion .github/workflows/test_fast.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ jobs:
flake8
etc/bin/shellchecker

# note: exclude python 3.10+ from mypy checks as these produce false
# positives in installed libraries for python 3.7
- name: Typing
if: startsWith(matrix.os, 'ubuntu')
if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.python-version, 3.9)
run: mypy

- name: Doctests
Expand Down