Fix IndepQueueManager test
#5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Nov 21, 2023
Comment on lines
-94
to
-97
| # check released tasks change state to "preparing", and not is_queued | ||
| for r in released: | ||
| assert r.state.reset.called_with(TASK_STATUS_PREPARING) | ||
| assert r.state.reset.called_with(is_queued=False) |
There was a problem hiding this comment.
itask.state.reset() is only ever called by TaskPool.release_queued_tasks(), so not applicable for this test
oliver-sanders
approved these changes
Nov 21, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Dec 5, 2023
…at_runtime * upstream/master: log_vc_info: handle long command output (cylc#5821) GH Actions: limit tutorial workflow to Py3.11 remove cylc task dependencies env var (cylc#5836) Refactor.lint (cylc#5718) protobuf 4.24.4 upgrade (cylc#5828) made reinstall work on multiple workflows Fix `IndepQueueManager` test (cylc#5832) Lint: Add a check for indentation being 4N spaces. (cylc#5772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5812
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry needed?.?.xbranch.