Ensure task mail respects [scheduler][mail]to/from
#6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
added
bug
MetRonnie
commented
Mar 5, 2024
tests/unit/test_task_events_mgr_2.py
Outdated
There was a problem hiding this comment.
Moved this into test_task_events_mgr.py. Not sure why there was ever a "2" file?
MetRonnie
commented
Mar 5, 2024
| def __init__( | ||
| self, workflow, proc_pool, workflow_db_mgr, broadcast_mgr, | ||
| xtrigger_mgr, data_store_mgr, timestamp, bad_hosts, | ||
| reset_inactivity_timer_func | ||
| ): | ||
| self.workflow = workflow | ||
| self.workflow_url = None |
wxtim
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5976
Plus tidy some cruft I spotted along the way (sorry, couldn't resist)
Note
db changeChange to the workflow database structure
- altered format of value in the
ctxcolumn in thetask_action_timerstable (with upgrader logic added to handle older DBs).Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.