Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix.sim mode no increment #6036

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fix.sim mode no increment #6036

merged 4 commits into from
Mar 28, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Mar 26, 2024 •
edited
Loading

Fixes a bug not otherwise reported:

Bug details

Using the following workflow

[scheduler]
  allow implicit tasks = true
[scheduling]
  [[graph]]
    R1 = foo
[runtime]
    [[foo]]
        [[[simulation]]]
            fail cycle points = all
            default run length = PT0S
            fail try 1 only = False

Open either TUI or GUI and see that the repeated tries to run the job are not displayed correctly:

image

The expected result is
image

(Thanks to @MetRonnie for the bug report)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request - N/A
  • This is a bugfix against a change introduced on master.

@wxtim wxtim self-assigned this Mar 26, 2024
@wxtim wxtim added the bug Something is wrong :( label Mar 26, 2024
@wxtim wxtim added this to the cylc-8.3.0 milestone Mar 26, 2024
@wxtim wxtim force-pushed the fix.sim_mode_no_increment branch from 6fefb92 to 655488a Compare March 26, 2024 15:07
MetRonnie
MetRonnie reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected 👍

changes.d/6036.fix.md Show resolved Hide resolved
tests/integration/test_task_events_mgr.py Outdated Show resolved Hide resolved
@wxtim @MetRonnie
Update tests/integration/test_task_events_mgr.py
e4f5669 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
MetRonnie reviewed Mar 27, 2024
View reviewed changes
changes.d/6036.fix.md Outdated Show resolved Hide resolved
wxtim and others added 2 commits March 28, 2024 08:16
@wxtim @MetRonnie
Update changes.d/6036.fix.md
4d1744d 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim
Merge branch 'master' into fix.sim_mode_no_increment
685387b
@wxtim wxtim requested a review from MetRonnie March 28, 2024 08:18
@MetRonnie MetRonnie merged commit 6ba2f8c into cylc:master Mar 28, 2024
23 of 25 checks passed
wxtim added a commit to wxtim/cylc that referenced this pull request Mar 28, 2024
@wxtim
Merge branch 'feature.skip_mode' of github.com:wxtim/cylc into featur…
68e41b7 
…e.skip_mode

* 'feature.skip_mode' of github.com:wxtim/cylc:
  Sim mode: fix job number not incrementing on retry (cylc#6036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@markgrahamdawson markgrahamdawson Awaiting requested review from markgrahamdawson

Assignees

@wxtim wxtim

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @MetRonnie