Refactor run mode restart check to avoid unclosed DB connection #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Mar 26, 2024
Comment on lines
-442
to
-443
| og_run_mode = self.workflow_db_mgr.get_pri_dao( | ||
| ).select_workflow_params_run_mode() or 'live' |
There was a problem hiding this comment.
This was causing the unclosed DB connection
wxtim
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently set up a new development environment in Python 3.11 on NFS. For some reason it is susceptible to an issue where the DB connection is not closed on restart causing integration test teardown to fail.
I traced this unclosed DB connection to #5789
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included as unlikely to be a problem for real workflows?.?.xbranch.