cylc lint S007: fix regex catastrophic backtracking
#6078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @ColemanTom |
MetRonnie
commented
Apr 22, 2024
Comment on lines
-245
to
-246
| param(item, id=str(ind)) | ||
| for ind, item in enumerate([ |
There was a problem hiding this comment.
Just using the index was making it kind of hard to tell which test cases were failing
wxtim
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
- Looks sensible
- Appears to work: I did a bit of profiling and it's fairly easy to replicate this bug on 8.2 seconds, but even when I went mad and thew
inherit = ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEQWERTYUIOPASDFGHJKZXCVBNM, WERTYUIOMNBVCDFTYUK, MNBVCF, POESOINDCN, SJOAIJOIKJNAK, X<fppp>, Onat the new branch it seemed to take approx 0.3 seconds.
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6075
Pertains to rule: S007 (family names should not contain lowercase chars)
Fixes ReDoS-like bug (possibly exponential scaling with length of input line).
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.