client: fix SSH client #6144
Merged
client: fix SSH client #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SSH->TCP client was missing the `ssh forward environment variables` key. * This PR gives it an empty placeholder value for now.
|
(assigning three reviewers, only need two, whoever gets there first) |
hjoliver
approved these changes
Jun 17, 2024
Booted Ronnie. |
wxtim
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug discovered when running local tests in preparation for 8.3.0 release.
ssh forward environment variableskey.To replicate the bug try:
$ ctb -p _remote_background_shared_ssh -v tests/functional/remote/02-install-target.tOr try running any of the other SSH client tests.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.