Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xtrigger validation: log traceback for unexpected user validation errors #6160

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Xtrigger validation: log traceback for unexpected user validation errors #6160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Xtrigger validation: log traceback for unexpected user validation errors
  • Loading branch information
@MetRonnie
MetRonnie committed Jun 17, 2024
commit 04de3037541b5e3e5550011412447a0b111904b0
4 changes: 3 additions & 1 deletion cylc/flow/xtrigger_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
)

from cylc.flow import LOG
from cylc.flow.exceptions import XtriggerConfigError
from cylc.flow.exceptions import WorkflowConfigError, XtriggerConfigError
import cylc.flow.flags
from cylc.flow.hostuserutil import get_user
from cylc.flow.subprocctx import add_kwarg_to_sig
Expand Down Expand Up @@ -362,6 +362,8 @@ def _try_xtrig_validate_func(
try:
xtrig_validate_func(bound_args.arguments)
except Exception as exc: # Note: catch all errors
if not isinstance(exc, WorkflowConfigError):
LOG.exception(exc)
raise XtriggerConfigError(label, signature_str, exc)

# BACK COMPAT: workflow_state_backcompat
Expand Down
Loading