Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks missing from pre_configure plugin #230

Closed
wxtim opened this issue Jun 13, 2023 · 1 comment
Closed

Checks missing from pre_configure plugin #230

wxtim opened this issue Jun 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented Jun 13, 2023

Description

Checks which are in the post-install plugin are missing from the pre-install step:

  • Warn about use of [jinja2:suite.rc (presumably [empy:suite.rc] too?).
  • Warn about root-dir.

Reproducible Example

#!/bin/bash
set -x
DIR="${HOME}/cylc-src/tmp.230"
mkdir -p "${DIR}"
cat > "${DIR}/rose-suite.conf" <<__HERE__
root-dir = ~/foo

[jinja2:suite.rc]
__HERE__

touch "${DIR}/suite.rc"

cylc validate "${DIR}"
# ... no warnings

cylc install "${DIR}"
# ... warnings

test.txt

Expected Behaviour

Cylc Rose should display this warning prior to installation.

@wxtim wxtim added the bug Something isn't working label Jun 13, 2023
@wxtim wxtim added this to the 1.2.1 milestone Jun 13, 2023
@wxtim wxtim self-assigned this Jun 13, 2023
@wxtim
Copy link
Member Author

wxtim commented Jun 13, 2023

Actual cause described in cylc/cylc-flow#5582 - which should close this tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant