Permitted warnings about root-dir for all versions of Cylc. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.root-dir_warning_applies_irrespective_of_compat_mode
branch
from
c3f7646
to
c1859f4
Compare
|
This is also broken on 1.2.x. https://github.com/cylc/cylc-rose/actions/runs/5266262439 |
for running Cylc installs.
oliver-sanders
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Tested with cylc/cylc-flow#5582, Rose warnings show as expected.
| @@ -42,6 +42,8 @@ | |||
| ROSE_ORIG_HOST_INSTALLED_OVERRIDE_STRING = ( | |||
| ' ROSE_ORIG_HOST set by cylc install.' | |||
| ) | |||
| MESSAGE = 'message' | |||
There was a problem hiding this comment.
FYI, if you find yourself coding dictionary keys as constants, then named tuples are likely a better fit.
8 tasks
|
Merged. |
|
@wxtim, I made a mistake deconflicting this, with the diff in the comment above this should work. |
MetRonnie
approved these changes
Jul 17, 2023
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Oct 9, 2023
…ow_--defines_no_equal * upstream/1.3.x: make RoseStemVersionException print the correct missing variable (cylc#252) Update tests/unit/test_rose_stem_units.py Allow top level settings in CLI Config (cylc#221) Prevent accidental manual setting of project name with -s= Fix flake8 Bump dev version Add missing dependency on ansimarkup Prepare release 1.3.0 Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 (cylc#236) Permitted warnings about root-dir for all versions of Cylc. (cylc#231) Bump pypa/gh-action-pypi-publish from 1.8.6 to 1.8.7 (cylc#235) Bump pypa/gh-action-pypi-publish from 1.8.5 to 1.8.6 (cylc#228) 1.3.0 (cylc#219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request closing an issue documented here:
Issue
This issue (#230) describes a rose suite configuration which raises warnings when cylc compatibility mode is turned off. The warning that
root-diris no longer valid at Cylc 8 is valid whether or not compatibility mode is turned on and should be shown in either case.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.