-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation updates for the nodeVersion
config option
#4194
Conversation
As of version 9.0.0, Cypress will use the same version of node that was used to launch the cypress App via the CLI. | ||
|
||
Prior to version 9.0.0, Cypress would use the version of node bundled with Cypress itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't keep notes like this in our docs for previous versions, the docs always reflect current version. In some cases we have a 'History' section in the file to explain changes
Can you update this section to reflect the truth of the new version?
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reread through the 'writing a plugins' page and it doesn't make sense to have this alert anymore I think, so I just removed the whole section. Looks good, we'll merge this into 9.0 as soon as the code PR is merged.
As a part of issue #18684, This PR updates the documentation to declare the
nodeVersion
config as deprecated as well as explain the defaultsystem
and behaviour, to use the same node binary that was used to launch cypress from the cli.