fix: warn when the projectRoot is not writeable

closes #18485
cypress-io · Oct 14, 2021 · 6889b11 · 6889b11
1 parent 7aac450
commit 6889b11
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/server/lib/modes/run.js b/packages/server/lib/modes/run.js
@@ -608,9 +608,22 @@ const openProjectCreate = (projectRoot, socketId, args) => {
   return openProject.create(projectRoot, args, options)
 }
 
-const createAndOpenProject = async function (socketId, options) {
+async function checkAccess (folderPath) {
+  return fs.access(folderPath).catch((err) => {
+    if (['EACCES', 'EPERM'].includes(err.code)) {
+      // we cannot write due to folder permissions
+      return errors.warning('FOLDER_NOT_WRITABLE', folderPath)
+    }
+
+    throw err
+  })
+}
+
+const createAndOpenProject = async (socketId, options) => {
   const { projectRoot, projectId } = options
 
+  await checkAccess(projectRoot)
+
   return openProjectCreate(projectRoot, socketId, options)
   .then((open_project) => open_project.getProject())
   .then((project) => {

diff --git a/packages/server/test/e2e/non_root_read_only_fs_spec.ts b/packages/server/test/e2e/non_root_read_only_fs_spec.ts
@@ -8,6 +8,9 @@ describe('e2e readonly fs', function () {
 
   const projectPath = Fixtures.projectPath('read-only-project-root')
 
+  /**
+   * Change permissions recursively
+   */
   const chmodr = (p: string, mode: number) => {
     const stats = fs.statSync(p)