Skip to content

Commit

Permalink
fix last flake
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanthemanuel committed Aug 29, 2023
1 parent 9a0481f commit ca7bad2
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 21 deletions.
1 change: 0 additions & 1 deletion packages/frontend-shared/cypress/e2e/e2ePluginSetup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ async function makeE2ETasks () {

// Handle any pre-loading that should occur based on the launch arg settings
await ctx.initializeMode()
await ctx.lifecycleManager.waitForInitializeSuccess()

return {
modeOptions,
Expand Down
21 changes: 1 addition & 20 deletions packages/launchpad/cypress/e2e/config-warning.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,26 +75,7 @@ describe('baseUrl', () => {
describe('experimentalSingleTabRunMode', () => {
it('is a valid config for component testing', () => {
cy.scaffoldProject('experimentalSingleTabRunMode')
cy.openProject('experimentalSingleTabRunMode', ['--component'])
cy.withCtx(async (ctx) => {
await ctx.actions.file.writeFileInProject('cypress.config.js', `
const { defineConfig } = require('cypress')
module.exports = defineConfig({
component: {
experimentalSingleTabRunMode: true,
devServer () {
// This test doesn't need to actually run any component tests
// so we create a fake dev server to make it run faster and
// avoid flake on CI.
return {
port: 1234,
close: () => {},
}
},
},
})`)
})
cy.openProject('experimentalSingleTabRunMode', ['--component', '--config-file', 'cypress-component-only.config.js'])

cy.visitLaunchpad()
cy.skipWelcome()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
const { defineConfig } = require('cypress')

module.exports = defineConfig({
component: {
experimentalSingleTabRunMode: true,
devServer () {
// This test doesn't need to actually run any component tests
// so we create a fake dev server to make it run faster and
// avoid flake on CI.
return {
port: 1234,
close: () => {},
}
},
},
})

0 comments on commit ca7bad2

Please sign in to comment.