Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open_project): remove unnecessary fn wrapping from tryToCalls #18146

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Sep 17, 2021

User facing changelog

  • Fixed an issue where Cypress could crash with a TypeError: openProject(...) is not a function error when connecting to Cypress Cloud.

Additional details

  • tryToCall was accidentally double-wrapped in a27793d
  • let's unwrap it a little

How has the user experience changed?

PR Tasks

  • [no] Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 17, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig marked this pull request as ready for review September 17, 2021 18:37
@flotwig flotwig requested a review from a team as a code owner September 17, 2021 18:37
@jennifer-shehane jennifer-shehane requested review from kuceb and tgriesser and removed request for chrisbreiding September 17, 2021 18:44
@cypress
Copy link

cypress bot commented Sep 17, 2021



Test summary

8371 3 103 3Flakiness 4


Run details

Project cypress
Status Failed
Commit 1be617b
Started Sep 17, 2021 6:54 PM
Ended Sep 17, 2021 7:05 PM
Duration 10:50 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

commands/actions/type_spec.js Failed
1 ... > element
e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus area
cypress/proxy-logging-spec.ts Failed
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps

Flakiness

cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
commands/xhr_spec.js Flakiness
1 ... > causes errors caused by onreadystatechange callback function
2 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig merged commit 1b989c5 into develop Sep 17, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 17, 2021

Released in 8.4.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.4.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 17, 2021
@tgriesser tgriesser deleted the issue-18129-fix-openProject-crash branch September 18, 2021 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when connecting to Dashboard
2 participants