-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-dev-server): replace UserConfig with InlineConfig to allow correct configFile
types
#18167
Conversation
Thanks for taking the time to open a PR!
|
configFile
typesconfigFile
types
Can any maintainers help me to fix the build issues. Each time I update my branch to be up-to-date with the base different tests fail.. I only changed a TypeScript type and it won't have affected any of the failing tests.. |
@mrmartineau I believe we merged something a bit quickly and there is a need to update yarn.lock for the vue tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch thank you
Hm, I wonder why |
Ok, it passes now. |
configFile
typesconfigFile
types
User facing changelog
Fixes a TypeScript error when specifying the
configFile
option for@cypress/vite-dev-server
.Additional details
When using the
configFile
option in@cypress/vite-dev-server
I recieved a TS error. This is because the TS types for thestartDevServer
method useUserConfig
from Vite, but that type does not include theconfigFile
property, howeverInlineConfig
does because it extends fromUserConfig
.I replaced references of
UserConfig
withInlineConfig
.FYI, the TS error message was:
How has the user experience changed?
There is no change to the user experience.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?