Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip windows canary check #22197

Merged
merged 5 commits into from
Jun 9, 2022
Merged

chore: skip windows canary check #22197

merged 5 commits into from
Jun 9, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 8, 2022

  • Closes

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig marked this pull request as ready for review June 8, 2022 16:14
@flotwig flotwig requested a review from tbiethman June 8, 2022 16:15
@cypress
Copy link

cypress bot commented Jun 8, 2022 •
edited
Loading


Test summary

37553 • 0 • 454 • 0 • Flakiness 7

Run details
Project cypress
Status Passed
Commit 3c692b6
Started Jun 8, 2022 9:15 PM
Ended Jun 8, 2022 9:32 PM
Duration 17:14 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

commands/actions/click.cy.js 2 Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
2 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/xhr.cy.js 1 Flakiness
1 ... > no status when request isnt forced 404
commands/navigation.cy.js 1 Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
next.cy.ts 1 Flakiness
1 Working with next-12 > should detect new spec
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990 referenced this pull request Jun 9, 2022
@github-actions @lmiller1990
chore: Update Chrome (stable) to 102.0.5005.61 and Chrome (beta) to 1…
f9d9d38 
…03.0.5060.33 (#21623)

Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
@lmiller1990 lmiller1990 self-requested a review June 9, 2022 01:45
@flotwig flotwig merged commit fccce5d into develop Jun 9, 2022
@flotwig flotwig deleted the rm-windows-key-scanning branch June 9, 2022 02:10
ryanthemanuel pushed a commit that referenced this pull request Jun 9, 2022
@flotwig @ryanthemanuel
chore: skip windows canary check (#22197)
434af20 
(cherry picked from commit fccce5d)
ryanthemanuel pushed a commit that referenced this pull request Jun 9, 2022
@flotwig @ryanthemanuel
chore: skip windows canary check (#22197)
f49fef7 
(cherry picked from commit fccce5d)
ryanthemanuel pushed a commit that referenced this pull request Jun 10, 2022
@flotwig @ryanthemanuel
chore: skip windows canary check (#22197)
56ef190
ryanthemanuel pushed a commit that referenced this pull request Jun 10, 2022
@flotwig @ryanthemanuel
chore: skip windows canary check (#22197)
13b26b6
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
@flotwig @BeijiYang
chore: skip windows canary check (cypress-io#22197)
31b852d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhenkes mjhenkes mjhenkes approved these changes

@AtofStryker AtofStryker AtofStryker approved these changes

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@tbiethman tbiethman Awaiting requested review from tbiethman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flotwig @mjhenkes @AtofStryker @ryanthemanuel @lmiller1990