Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only run Windows on main branches #22822

Merged
merged 1 commit into from
Jul 15, 2022
Merged

chore: only run Windows on main branches #22822

merged 1 commit into from
Jul 15, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 15, 2022

User facing changelog

Additional details

  • Removes Windows from PRs and branch builds by default, cuz It's expensive, yo. And we don't need to do this as badly now that we aren't rapidly iterating on 10.0 pre-releases. We will be forced to reckon with Windows every 2 weeks like in the pre-10.0 days.

Steps to test

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 15, 2022

Thanks for taking the time to open a PR!

name: windows-lint
executor: windows
requires:
- windows-build

- unit-tests:
<<: *full-windows-workflow-filters
name: windows-unit-tests
executor: windows
resource_class: windows.large
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to back this off to medium? Or do we want to explore that separately?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it looks like it's still too flaky 😕 #22821

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadness. Oh well this is a good option for now! 👍🏻

@flotwig flotwig merged commit 467b2c9 into develop Jul 15, 2022
@flotwig flotwig deleted the windows-no-prs branch July 15, 2022 22:45
@cypress
Copy link

cypress bot commented Jul 15, 2022



Test summary

37721 0 456 0Flakiness 10


Run details

Project cypress
Status Passed
Commit 9a28a00
Started Jul 15, 2022 10:31 PM
Ended Jul 15, 2022 10:49 PM
Duration 17:51 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
xhr.cy.js Flakiness
1 ... > logs response
2 ... > logs request + response headers
3 ... > logs Method, Status, URL, and XHR
4 ... > logs response
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants