fix: AttemptResult object #26569

Ioanna2001 · 2023-04-23T21:32:23Z

Closes Wrong 'AttemptResult' TS type #24110

Additional details

Fields are added to AttempResult object
This change is necessary in order to correspond to the current TestResult properties

Steps to test

Create a test with retries
Log the currentTestResult
Check the object's properties

PR tasks

Changed duartion to wallClockDuration
Changed startedAt to wallClockStartedAt
Added failedFromHookId
Added timings
TODO: Should Timings object be created?
TODO: Should documentation be updated?

Questions for reviewers

Should a Timings object be created?
Should additional properties be added to AttemptResult object other than those specified in the issue?

* Changed duartion to wallClockDuration * Changed startedAt to wallClockStartedAt * Added failedFromHookId * Added timings * TODO: Should Timings object be created? * TODO: Should documentation be updated?

CLAassistant · 2023-04-23T21:32:27Z

All committers have signed the CLA.

nagash77 · 2023-06-07T14:31:05Z

Unfortunately we have to close this issue due to inactivity. Please comment if there is new information to provide concerning the original issue and we can reopen.

Ioanna2001 · 2023-06-07T20:41:04Z

Hello, I will keep on working on this issue I have just been busy with work and school. I am picking it up again soon.

jnovoadeuna · 2023-06-23T13:30:05Z

@Ioanna2001 Thank you very much for your interest in solving this problem. I'm currently having the same problem that you solve with this PR, I'm looking forward to it being merged. Thanks again for your contribution.

* Added Timings interface that was missing from AttemptResult

cypress · 2023-06-25T16:27:42Z

32 flaky tests on run #48201 ↗︎

0	27897	1348	0	32

Details:

Remove mixed up folder
Project: cypress	Commit: `ee2898a60a`
Status: Passed	Duration: 20:23 💡
Started: Jun 25, 2023 7:39 PM	Ended: Jun 25, 2023 8:00 PM

create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
... > runs generated spec		`Output` `Screenshots` `Video`

specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		`Output` `Screenshots` `Video`

cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found		`Output` `Screenshots` `Video`

cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution		`Output` `Screenshots` `Video`

commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse		`Output` `Video`

The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

mike-plummer · 2023-06-28T15:15:21Z

@Ioanna2001 I made a few updates based on a quick look at the code; seems like the timings and hookInformation fields can potentially be null, and there's sometimes a hookId field supplied to a Timing based on how it's triggered. Also made a tweak to the changelog entry. LMK if you disagree with any of it.

I'll track down another approver and get this merged assuming everything on CI comes back green

cli/types/cypress-npm-api.d.ts

lmiller1990 · 2023-06-29T00:02:34Z

cli/types/cypress-npm-api.d.ts

  interface AttemptResult {
    state: string
    error: TestError | null
-    startedAt: dateTimeISO
-    duration: ms
+    wallClockStartedAt: dateTimeISO


These seem correct.

mike-plummer · 2023-06-30T13:54:57Z

@Ioanna2001 Thanks for the contribution, sorry it took us a while to get it merged in. This will be included in our next release

Ioanna2001 · 2023-06-30T15:31:35Z

@mike-plummer Thank you for the help and the update, I'm really glad I was able to help. Looking forward for the release!

cypress-bot · 2023-07-06T17:13:19Z

Released in 12.17.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.0, please open a new issue.

Change AttemptResult object

e509b0d

* Changed duartion to wallClockDuration * Changed startedAt to wallClockStartedAt * Added failedFromHookId * Added timings * TODO: Should Timings object be created? * TODO: Should documentation be updated?

Ioanna2001 changed the title ~~Fix AttemptResult object~~ fix: AttemptResult object Apr 23, 2023

Ioanna2001 marked this pull request as ready for review April 23, 2023 21:37

Ioanna2001 marked this pull request as draft April 23, 2023 21:38

nagash77 closed this Jun 7, 2023

nagash77 reopened this Jun 7, 2023

nagash77 closed this Jun 7, 2023

nagash77 reopened this Jun 8, 2023

Ioanna2001 and others added 3 commits June 24, 2023 20:41

Merge branch 'cypress-io:develop' into issue-24110

1e09467

Add Timings interface

fd2a2e1

* Added Timings interface that was missing from AttemptResult

Add changelog entry

1cffad2

Ioanna2001 marked this pull request as ready for review June 25, 2023 15:55

Ioanna2001 marked this pull request as draft June 25, 2023 15:58

Fix syntax errors

8194629

Ioanna2001 marked this pull request as ready for review June 25, 2023 17:06

Remove mixed up folder

ee2898a

Ioanna2001 marked this pull request as draft June 25, 2023 19:19

Ioanna2001 marked this pull request as ready for review June 25, 2023 19:29

mike-plummer self-assigned this Jun 28, 2023

mike-plummer and others added 3 commits June 28, 2023 10:09

Update types

efc5e0c

Merge branch 'develop' into issue-24110

3f19aa6

Fix changelog

145a702

mike-plummer approved these changes Jun 28, 2023

View reviewed changes

mike-plummer requested a review from lmiller1990 June 28, 2023 15:16

lmiller1990 reviewed Jun 29, 2023

View reviewed changes

lmiller1990 added 2 commits June 30, 2023 09:17

remove private types from public api

d2e263d

merge develop

2150f94

lmiller1990 force-pushed the issue-24110 branch from bb37620 to 2150f94 Compare June 29, 2023 23:20

lmiller1990 self-requested a review June 29, 2023 23:21

lmiller1990 approved these changes Jun 29, 2023

View reviewed changes

lmiller1990 and others added 2 commits June 30, 2023 09:22

revert

7fea0ab

fix changelog

cf7dca7

mike-plummer merged commit df437cd into cypress-io:develop Jun 30, 2023

cypress-bot bot locked as resolved and limited conversation to collaborators Jul 6, 2023

Ioanna2001 deleted the issue-24110 branch September 11, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: AttemptResult object #26569

fix: AttemptResult object #26569

Ioanna2001 commented Apr 23, 2023

CLAassistant commented Apr 23, 2023 •

edited

Loading

nagash77 commented Jun 7, 2023

Ioanna2001 commented Jun 7, 2023

jnovoadeuna commented Jun 23, 2023

cypress bot commented Jun 25, 2023 •

edited

Loading

mike-plummer commented Jun 28, 2023

lmiller1990 Jun 29, 2023

mike-plummer commented Jun 30, 2023

Ioanna2001 commented Jun 30, 2023

cypress-bot bot commented Jul 6, 2023

fix: AttemptResult object #26569

fix: AttemptResult object #26569

Conversation

Ioanna2001 commented Apr 23, 2023

Additional details

Steps to test

PR tasks

Questions for reviewers

CLAassistant commented Apr 23, 2023 • edited Loading

nagash77 commented Jun 7, 2023

Ioanna2001 commented Jun 7, 2023

jnovoadeuna commented Jun 23, 2023

cypress bot commented Jun 25, 2023 • edited Loading

32 flaky tests on run #48201 ↗︎

mike-plummer commented Jun 28, 2023

lmiller1990 Jun 29, 2023

Choose a reason for hiding this comment

mike-plummer commented Jun 30, 2023

Ioanna2001 commented Jun 30, 2023

cypress-bot bot commented Jul 6, 2023

CLAassistant commented Apr 23, 2023 •

edited

Loading

cypress bot commented Jun 25, 2023 •

edited

Loading