Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .clear support for HTML 5 input types #2793

Merged
merged 7 commits into from
Nov 20, 2018

Conversation

lilaconlee
Copy link
Contributor

Think directly setting this value might overstep something that's happening in type, but not entirely sure.

@lilaconlee lilaconlee changed the title WIP: Add clear support for HTML 5 input types Add clear support for HTML 5 input types Nov 16, 2018
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I prematurely approved this. I think it probably is an issue that this is no longer going through cy.type(). We need to ensure all the appropriate events (like change) get fired as a result of clearing the input.

@lilaconlee lilaconlee modified the milestone: Sprint 12 Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants