-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle malformed URIs in prerequests #28522
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
approved these changes
Dec 13, 2023
jennifer-shehane
approved these changes
Dec 13, 2023
6 flaky tests on run #52797 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta
commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta
commands/files.cy.js • 1 flaky test • 5x-driver-chrome:beta
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta
Review all test suite changes for PR #28522 ↗︎ |
ryanthemanuel
approved these changes
Dec 14, 2023
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In #28427 we started decoding URIs during the prerequest logic to resolve some correlation timeouts. However, we are not correctly handling malformed URIs which will cause Cypress to crash. This change tries to decode the URI and if it fails, just falls back to using the URI as-is for correlation.
Steps to test
How has the user experience changed?
Cypress no longer crashes when receiving a malformed URI.
PR Tasks
cypress-documentation
?type definitions
?