Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove percy snapshots for flaky snapshots containing tooltips #28897

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

jennifer-shehane
Copy link
Member

Additional details

We have a few snapshot tests in Percy with tooltips that I'm proposing removing:

  • The tooltip sometimes shows and sometimes doesn't in the test - it doesn't seem very much under our control looking at the test code.
  • The behavior of the tooltip showing is being tested already within the test, so we're not losing functional testing

We will potentially lose some coverage on the styling of the tooltips, but I would argue with as much flake that we're seeing - probably no one would accurately identify there is a problem with the tooltip styling since it's mostly ignored.

Steps to test

We'll see the percy checks and ensure there's no approvals needed that show flake.

How has the user experience changed?

N/A

PR Tasks

N/A

@jennifer-shehane jennifer-shehane self-assigned this Feb 8, 2024
Copy link

cypress bot commented Feb 9, 2024

1 flaky test on run #53973 ↗︎

0 5502 73 0 Flakiness 1

Details:

Merge branch 'develop' into fix-percy-snapshot-flake
Project: cypress Commit: a36bb4983b
Status: Passed Duration: 16:36 💡
Started: Feb 9, 2024 7:43 PM Ended: Feb 9, 2024 7:59 PM
Flakiness  cypress/e2e/e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
delayed navigation > errors > redirects to an unexpected cross-origin Test Replay

Review all test suite changes for PR #28897 ↗︎

@jennifer-shehane jennifer-shehane merged commit abbd7b4 into develop Feb 9, 2024
80 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the fix-percy-snapshot-flake branch February 9, 2024 20:48
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 20, 2024

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants