chore: fix flaky debug progress test #28958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 flaky tests on run #54074 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| network stubbing > waiting and aliasing > yields the expected interception when two requests are raced |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| network stubbing > waiting and aliasing > yields the expected interception when two requests are raced |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.
Review all test suite changes for PR #28958 ↗︎
AtofStryker
approved these changes
Feb 22, 2024
mschile
approved these changes
Feb 22, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We have a debug test that is testing a progress bar. This test is not actually written in a way where we are manually polling the progress bar, then asserting. It just has an interval that ticks the progress bar. Sometimes the tests wouldn't make it to the first 1/3 tests assertions until the progress bar had already gone to 2/3, causing this test to be flaky.
In this PR, I've increased the polling interval from 1 sec to 1.5 sec. I've also rearranged some of the tests and assertions to get to the 1/3 assertion more quickly. I also reduced the number of specs we're looking for from 5 to 3, otherwise we're waiting an extra 3 seconds for the progress bar to finish on things we're not even asserting on. This solution could probably be better, but hopefully this fixes most of the issues.
Failing case
Passing case
Steps to test
Run the debug.cy.ts test locally.
How has the user experience changed?
N/A