Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update command message to truncate command info at 100 lines instead of 50 #29032

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Feb 28, 2024

Additional details

We currently truncate the command message in the Cypress command log to 50 lines. The main concern around truncating that I ran into is that full URLs are not visible, the trail off with ellipsis. This hasn't been a big problem in cypress open because you can just click on the command and see the full URL in devtools. However, since we use the reporter css for Test Replay, this URL is not visible in Test Replay. You'd have to remove the css from devTools to see it. This change will need to be ported over to Test Replay.

This behavior of truncating the command messages has a long history and there's been a series of states when it comes to truncating the command messages in the Cypress command log. I was trying to track down the true intention behind what we want as a product. In the end, I think it's best to make the truncation slightly longer.

One thing of note is that it's generally accepted to keep URLs below 2000 chars, so that may be a consideration for this.

Steps to test

How has the user experience changed?

Before

Screenshot 2024-02-28 at 10 27 17 AM

After

Screenshot 2024-02-28 at 10 27 28 AM

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Feb 28, 2024
Copy link

cypress bot commented Feb 28, 2024

10 flaky tests on run #54449 ↗︎

0 29111 1324 0 Flakiness 10

Details:

Merge branch 'develop' into untruncate-command-message
Project: cypress Commit: 347e65c14d
Status: Passed Duration: 19:37 💡
Started: Mar 11, 2024 2:00 PM Ended: Mar 11, 2024 2:19 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws after timing out after a .wait() alias reference Test Replay
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > waits for requestTimeout and responseTimeout override Test Replay
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > establishes foobar spec bridge Test Replay
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay

The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.

Review all test suite changes for PR #29032 ↗︎

cli/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@jennifer-shehane jennifer-shehane changed the title misc: update command message to not truncate command info misc: update command message to truncate command info at 100 lines instead of 50 Feb 29, 2024
@AtofStryker AtofStryker self-requested a review March 11, 2024 13:53
@jennifer-shehane jennifer-shehane merged commit d55659c into develop Mar 11, 2024
80 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the untruncate-command-message branch March 11, 2024 19:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 13, 2024

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not shorten command message text with ellipsis
3 participants