-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: update command message to truncate command info at 100 lines instead of 50 #29032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 flaky tests on run #54449 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
... > throws after timing out after a .wait() alias reference |
Test Replay
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > waits for requestTimeout and responseTimeout override |
Test Replay
|
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > establishes foobar spec bridge |
Test Replay
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
Test | Artifacts | |
---|---|---|
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced |
Test Replay
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
Review all test suite changes for PR #29032 ↗︎
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
emilyrohrbough
approved these changes
Feb 29, 2024
AtofStryker
approved these changes
Mar 11, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We currently truncate the command message in the Cypress command log to 50 lines. The main concern around truncating that I ran into is that full URLs are not visible, the trail off with ellipsis. This hasn't been a big problem in
cypress open
because you can just click on the command and see the full URL in devtools. However, since we use the reporter css for Test Replay, this URL is not visible in Test Replay. You'd have to remove the css from devTools to see it. This change will need to be ported over to Test Replay.This behavior of truncating the command messages has a long history and there's been a series of states when it comes to truncating the command messages in the Cypress command log. I was trying to track down the true intention behind what we want as a product. In the end, I think it's best to make the truncation slightly longer.
One thing of note is that it's generally accepted to keep URLs below 2000 chars, so that may be a consideration for this.
Steps to test
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?