chore: unskip some tests that were previously flaky #29037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #54281 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #29037 ↗︎
AtofStryker
approved these changes
Mar 6, 2024
cacieprins
approved these changes
Mar 8, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Unskipping some tests that were previously skipped. I noticed in our UI Coverage scoring that we had no coverage on the buttons that click to choose a browser, which led me to see that we had skipped all of these tests. There's a bug with how we're detecting UI Coverage of this element though, so this doesn't actually increase our score atm.
When running them, they seem to pass consistently, but I'll track if this introduces more flake. The guarding of loading the page added in previous PRs may have addressed the previous flake.
I tried to unskip an extra one, but it was still flaky 😢
Steps to test
See the tests pass.
How has the user experience changed?
N/A