chore: move questions-remain into cypress repo #29542
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| exports['questions-remain returns object if all questions have been answered 1'] = { | ||
| 'foo': 'foo is specified', | ||
| 'bar': 'so is bar', | ||
| } | ||
|
|
||
| exports['questions-remain asks questions for missing options 1'] = { | ||
| 'foo': 'foo is specified', | ||
| 'bar': 'bar user answer', | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| const la = require('lazy-ass') | ||
| const is = require('check-more-types') | ||
| const bluebird = require('bluebird') | ||
|
|
||
| // goes through the list of properties and asks relevant question | ||
| // resolves with all relevant options set | ||
| // if the property already exists, skips the question | ||
| function askMissingOptions (propertiesToQuestions) { | ||
| la(is.object(propertiesToQuestions), 'expected object property:question') | ||
|
|
||
| // options are collected from the CLI | ||
| return (options = {}) => { | ||
| const reducer = (memo, property) => { | ||
| if (is.has(memo, property)) { | ||
| return memo | ||
| } | ||
|
|
||
| const question = propertiesToQuestions[property] | ||
|
|
||
| if (!is.fn(question)) { | ||
| return memo | ||
| } | ||
|
|
||
| la(is.fn(question), 'cannot find question for property', property) | ||
|
|
||
| return question(memo[property]).then((answer) => { | ||
| memo[property] = answer | ||
|
|
||
| return memo | ||
| }) | ||
| } | ||
|
|
||
| const properties = Object.keys(propertiesToQuestions) | ||
|
|
||
| return bluebird.reduce(properties, reducer, options) | ||
| } | ||
| } | ||
|
|
||
| module.exports = askMissingOptions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* global sinon */ | ||
|
There was a problem hiding this comment. |
||
| const questionsRemain = require('../../../binary/util/questions-remain') | ||
| const la = require('lazy-ass') | ||
| const snapshot = require('snap-shot-it') | ||
|
|
||
| describe('questions-remain', () => { | ||
| const dontAsk = () => { | ||
| throw new Error('Should not ask!') | ||
| } | ||
|
|
||
| it('is a function', () => { | ||
| if (typeof questionsRemain !== 'function') throw new Error('questionsRemain is not a function') | ||
|
There was a problem hiding this comment. I removed the |
||
| }) | ||
|
|
||
| it('returns object if all questions have been answered', () => { | ||
| const propertiesToQuestions = { | ||
| foo: dontAsk, | ||
| bar: dontAsk, | ||
| } | ||
| const options = { | ||
| foo: 'foo is specified', | ||
| bar: 'so is bar', | ||
| } | ||
|
|
||
| // console.log(questionsRemain(propertiesToQuestions)(options)) | ||
| return questionsRemain(propertiesToQuestions)(options).then(snapshot) | ||
|
There was a problem hiding this comment. These are promises, so chain |
||
| }) | ||
|
|
||
| it('asks questions for missing options', () => { | ||
| const barStub = sinon.stub().resolves('bar user answer') | ||
| const propertiesToQuestions = { | ||
| foo: dontAsk, | ||
| bar: barStub, | ||
| } | ||
| const options = { | ||
| foo: 'foo is specified', | ||
| // notice bar is missing! | ||
| } | ||
|
|
||
| return questionsRemain(propertiesToQuestions)(options) | ||
| .then(snapshot) | ||
| .then(() => { | ||
| la(barStub.called, 'bar stub has not been called') | ||
| }) | ||
| }) | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having issues with snapshot and though this would fix it. Seems like a good change even though it's not needed for this update.