breaking: Remove support for Node.js 16, Node.js 21, and glibc < 2.28 #30307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Remove Node.js 16 and Node.js 21 support
jennifer-shehane
changed the title
jennifer-shehane
changed the title
jennifer-shehane
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-node-16-21-support
|
| Run status |
|
| Run duration | 25m 22s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29395
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.77%
|
|
|---|---|
|
Untested elements
|
201
|
|
Tested elements
|
167
|
Accessibility
91.29%
|
|
|---|---|
|
Failed rules
|
5 critical
10 serious
2 moderate
2 minor
|
|
Failed elements
|
943
|
jennifer-shehane
changed the title
AtofStryker
approved these changes
Sep 30, 2024
| @@ -5,6 +5,9 @@ _Released 12/3/2024 (PENDING)_ | |||
|
|
|||
| **Breaking Changes:** | |||
|
|
|||
| - Removed support for Node.js 16 and Node.js 21. Addresses [#29930](https://github.com/cypress-io/cypress/issues/29930). | |||
| - Prebuilt binaries for Linux are no longer compatible with Linux distributions based on glibc <2.28, for example: Ubuntu 14-18, RHEL 7, CentOS 7, Amazon Linux 2. Addresses [#29601](https://github.com/cypress-io/cypress/issues/29601). | |||
There was a problem hiding this comment.
somewhere we want to note that debian 10 is the target build for better-sqlite3 so if we bump the docker image base to bookworm we need to be aware to then build better-sqlite3 against the supported glibc version, which is currently 2.28.
ryanthemanuel
approved these changes
Oct 1, 2024
mschile
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We don't have any tests for 16 or 21 currently, so no need to remove those: https://github.com/cypress-io/cypress/blob/remove-node-16-21-support/system-tests/test-binary/node_versions_spec.ts#L27
Steps to test
Not much right now actually
How has the user experience changed?
Cypress may not work properly in Node.js 16 and 21 moving forward.
PR Tasks
cypress-documentation?type definitions?