Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect arch from CYPRESS_ARCH #30366

Closed
wants to merge 1 commit into from

Conversation

saschanaz
Copy link

Additional details

Steps to test

Set $CYPRESS_ARCH when npm install

How has the user experience changed?

PR Tasks

(I want to get some feedback before checking PR tasks)

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@saschanaz saschanaz marked this pull request as draft October 6, 2024 08:19
@MikeMcC399
Copy link
Contributor

@saschanaz

See comment in #30252 (comment). I would expect that any change to allow win32-arm64 usage would need CI support for this architecture, so it may be too early for a PR to modify the installation process.

@saschanaz
Copy link
Author

I edited previous comment, the validation bypass is the only actual missing part. I'll open another PR.

@saschanaz saschanaz closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants