Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update JQuery to 3.0.0 #3575

Closed
wants to merge 59 commits into from
Closed

[WIP] Update JQuery to 3.0.0 #3575

wants to merge 59 commits into from

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Feb 24, 2019

Ref: #1229
Closes #1215

@jennifer-shehane
Copy link
Member

Hey @Saibamen, if you could, rename the PR title to have [WIP] if you are still working through this issue.

When you're ready for an official pull request review, choose a reviewer (if possible) and remove the [WIP] from the title.

@Saibamen Saibamen changed the title Update JQuery to 3.0.0 [WIP] Update JQuery to 3.0.0 Feb 27, 2019
@Saibamen
Copy link
Contributor Author

Saibamen commented Jun 3, 2019

can type into an iframe with designmode = 'on' from type_spec.coffee is failing. I don't know how to fix this

@jennifer-shehane
Copy link
Member

Test failures:

Screenshots are different sizes in jQuery update in cypress/packages/server/test/e2e/5_screenshots_spec.coffee

-  - /foo/bar/.projects/e2e/cypress/screenshots/screenshots_spec.coffee/taking screenshots -- really long test title aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.png (1000x660)
-  - /foo/bar/.projects/e2e/cypress/screenshots/screenshots_spec.coffee/taking screenshots -- really long test title aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa (1).png (1000x660)
+  - /foo/bar/.projects/e2e/cypress/screenshots/screenshots_spec.coffee/taking screenshots -- really long test title aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.png (1000x548)
+  - /foo/bar/.projects/e2e/cypress/screenshots/screenshots_spec.coffee/taking screenshots -- really long test title aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa (1).png (1000x548)

undefined printing in error message instead of element in

  • cypress/packages/server/test/e2e/3_issue_173_spec.coffee
  • cypress/packages/server/test/e2e/2_config_spec.coffee
  • cypress/packages/server/test/e2e/1_caught_uncaught_hook_errors_spec.coffee
-     CypressError: Timed out retrying: Expected to find element: 'element_does_not_exist', but never found it.
+     CypressError: Timed out retrying: Expected to find element: 'undefined', but never found it.

@Saibamen
Copy link
Contributor Author

Merged latest develop branch.
Need help with that PR

@chrisbreiding
Copy link
Contributor

Closing in favor of #1229

@Saibamen Saibamen deleted the issue-1215-jquery branch September 25, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgade jQuery dependency to 3.x
3 participants