Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cy.once typings #4788

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Fix the cy.once typings #4788

merged 2 commits into from
Jul 23, 2019

Conversation

NoriSte
Copy link
Contributor

@NoriSte NoriSte commented Jul 23, 2019 •
edited
Loading

The cy.once function has not the corresponding types, I get the

Property 'once' does not exist on type 'Chainable'.ts(2339)

error while using it in a TS file (see the screenshot below).

I duplicated the cy.on signature and added the tests, let me know if I have to do something more 😊

Screen Shot 2019-07-23 at 13 54 10

Pre-merge Tasks

  • Have the type definitions been updated with any user-facing API changes?
  • Have tests been added/updated for the changes in this PR?

Thank you guys 👋

@jennifer-shehane jennifer-shehane requested a review from a team July 23, 2019 17:42
@brian-mann brian-mann merged commit abc996e into cypress-io:develop Jul 23, 2019
@bahmutov
Copy link
Contributor

nice @NoriSte

@NoriSte NoriSte deleted the fix-cy-once-typings branch July 23, 2019 20:41
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoriSte @bahmutov @brian-mann @flotwig