-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async timeouts #5097
Fix async timeouts #5097
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
packages/driver/test/cypress/integration/cypress/runner_spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay this looks great! Will merge in after the keys are fixed. 👍
Does this PR also fix #4742 ? |
* fix async timeouts * add tests * add asyncTestTimeout config value * fix angular_spec, add timeout test * fix connectors_spec * fix querying_spec * fix e2e test e2e_config_fails * fix e2e specs, change calls to cy.timeout() * remove added config value, use `defaultCommandTimeout` * fix timing out internal tests * cleanup * add e2e test for async timeout after cy command * [review] remove most of runner_spec * add back runner_spec, whoops
Released in |
fix async tests with
done
callbacks never timing out after cypress commandadd config value forasyncTestTimeout
(default4000
)user facing changes
done
callback will now timeout afterdefaultCommandTimeout
after all commands have runtasks
defaultCommandTimeout
asasyncTestTimeout
(for now)Pre-merge Tasks