Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kaggle-dog.md #2274

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Update kaggle-dog.md #2274

merged 1 commit into from
Aug 28, 2022

Conversation

Sere1nz
Copy link
Contributor

@Sere1nz Sere1nz commented Aug 28, 2022

In line 495, softmax should be done on dim=1. Ouput shape of net is (128,120). dim = 0 is the dimension of batchsize. Softmax should be done over dim=1 which is 120 classes.

Description of changes:

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

In line 495, softmax should be done on dim=1. Ouput shape of net is (128,120). dim = 0 is the dimension of batchsize. Softmax should be done over dim=1 which is 120 classes.
@d2l-bot
Copy link
Member

d2l-bot commented Aug 28, 2022

Job d2l-en/PR-2274/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2274/

Copy link
Member

@AnirudhDagar AnirudhDagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sere1nz for the fix, that is indeed correct.

@AnirudhDagar AnirudhDagar merged commit da16482 into d2l-ai:master Aug 28, 2022
@AnirudhDagar
Copy link
Member

@Sere1nz Could you please send another PR to replace your id with your name in our acknowledgement?

Sakaizd added a commit to Sakaizd/d2l-zh that referenced this pull request Aug 30, 2022
Synchronize upstream modification from:  d2l-ai/d2l-en#2274
astonzhang pushed a commit to d2l-ai/d2l-zh that referenced this pull request Dec 4, 2022
Synchronize upstream modification from:  d2l-ai/d2l-en#2274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants