Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle the front chain before computing the enclosing circle. #83

Closed
mbostock opened this issue Apr 30, 2017 · 2 comments
Closed

Shuffle the front chain before computing the enclosing circle. #83

mbostock opened this issue Apr 30, 2017 · 2 comments
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

mbostock commented Apr 30, 2017 •
edited
Loading

Computing the enclosing circle of the front-chain in order is slower than computing it in random order because the enclosing circle takes longer to approximate its final value.

In order (e.g., 854 steps):

enclose-in-order

In random order (e.g., 226 steps):

enclose-random-order
@mbostock mbostock self-assigned this Apr 30, 2017
@mbostock
Copy link
Member Author

The worst part is I have a function named shuffle that doesn’t shuffle. 😝

@mbostock mbostock mentioned this issue May 8, 2017
Closed
mbostock added a commit that referenced this issue May 19, 2017
@mbostock
Rename shuffle to list.
709eefa 
Related #83.
@mbostock
Copy link
Member Author

/cc @robinhouston

Fil added a commit that referenced this issue Feb 28, 2022
@Fil
deterministic shuffling
0248e2c 
fixes #189
note: shuffling is here to increase performance (#83)
@Fil Fil mentioned this issue Feb 28, 2022
Merged
Fil added a commit that referenced this issue Feb 28, 2022
@Fil
deterministic shuffling (#190)
9e0ac43 
fixes #189
note: shuffling is here to increase performance (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock