Use inline style value, if present. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always returning the computed style value, selection.style now favors the inline value, if present, and only falls back to the computed value if an inline value is not present. By not computing the style value in the common case where an inline style is present, this is faster, but more importantly it is more predictable, since a computed value can be surprisingly different from an inline value, such as when the inline value is specified as a percentage. This change is especially useful for transition.style, d3/d3-transition#47, so that you can control the starting style value of a transition.
mbostock
added a commit
to d3/d3-transition
that referenced
this pull request
Mar 8, 2017
Rather than always starting from the computed style value, transition.style now favors the inline value, if present, and only falls back to the computed value if an inline value is not present. By not computing the style value in the common case where an inline style is present, this is faster, but more importantly it is more predictable since a computed value can be surprisingly different from an inline value, such as when the inline value is specified as a percentage. Related d3/d3-selection#120. Fixes #47.
mbostock
added a commit
to d3/d3-transition
that referenced
this pull request
May 15, 2017
Rather than always starting from the computed style value, transition.style now favors the inline value, if present, and only falls back to the computed value if an inline value is not present. By not computing the style value in the common case where an inline style is present, this is faster, but more importantly it is more predictable since a computed value can be surprisingly different from an inline value, such as when the inline value is specified as a percentage. Related d3/d3-selection#120. Fixes #47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always returning the computed style value, selection.style now favors the inline value if present, and only falls back to the computed value if an inline value is not present.
By not computing the style value in the common case where an inline style is present, this is faster, but more importantly it is more predictable, since a computed value can be surprisingly different from an inline value, such as when the inline value is specified as a percentage.
This change is especially useful for transition.style, d3/d3-transition#47, so that you can control the starting style value of a transition.