Fix issue with hardcoded local to en_US #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_LinkedInLocalInfo updated getting the first value of json map, avoiding error if user has no en_US name.
|
Please, i need this change ASAP |
d3xt3r2909
requested changes
Apr 28, 2020
lib/src/linked_in_user_model.dart
Outdated
| @@ -68,7 +68,7 @@ class _LinkedInLocalInfo { | |||
|
|
|||
| factory _LinkedInLocalInfo.fromJson(Map<String, dynamic> json) => | |||
| _LinkedInLocalInfo( | |||
| label: json['en_US'], // possible error | |||
| label: json.values.toList()[0], // possible error | |||
There was a problem hiding this comment.
We need a more secure way. Hardcoding can produce the same issue in this place. I will add more lines, so that we can merge it.
d3xt3r2909
changed the title
d3xt3r2909
approved these changes
Apr 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_LinkedInLocalInfo updated getting the first value of json map, avoiding error if user has no en_US name.