Adds entry file directory as module directory #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. I'll test it today on my few other projects which uses aik and if everything is ok will merge it. Thanks a lot for the pull request. |
|
Just for sticking to conventional changelog requirements can you please change title of commit message to something like this: "feat(webpack): Adds entry file directory as module directory" |
a-s-o
force-pushed
the
module-directory-support
branch
from
c9f68ea
to
b42c0af
Compare
|
Done, title updated. |
|
Merged. Thanks a lot for pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
Tells webpack to search in the entry file directory for modules, along with the default webpack modulesDirectories.
We can discuss which directory should be searched for first but my rationale is that the type of folders I will have in my base dir, such as "models", "reducers", "styles", "components", etc. will generally not conflict with packages I have installed. In the event that they do conflict, it is easier for me to resolve the conflict by renaming my folders than it is to alias an npm package.
Finally, I ran this change against the aik-examples and this does not cause an issue on my system.