Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/optimize: print SubscriptionTag in AliveDialerSet::printLatencies() #319

Merged
merged 1 commit into from
Sep 3, 2023
Merged

feat/optimize: print SubscriptionTag in AliveDialerSet::printLatencies() #319

merged 1 commit into from
Sep 3, 2023

Conversation

luochen1990
Copy link
Contributor

@luochen1990 luochen1990 commented Sep 3, 2023 •
edited by mzz2017
Loading

Background

print SubscriptionTag so that we can know each node is from which Subscription

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@luochen1990 luochen1990 requested a review from a team as a code owner September 3, 2023 10:10
mzz2017
mzz2017 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you paste the screenshot of the result?

@piyoki piyoki changed the title optimize: print SubscriptionTag in AliveDialerSet::printLatencies() feat/optimize: print SubscriptionTag in AliveDialerSet::printLatencies() Sep 3, 2023
@piyoki piyoki added the feature label Sep 3, 2023
@luochen1990
Copy link
Contributor Author

It's like:
[subscription_tag] node_name: 50ms(+1s=1.05s)

dae-prow[bot]
dae-prow bot approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit bfd4d99 into daeuniverse:main Sep 3, 2023
19 checks passed
@mzz2017
Copy link
Contributor

mzz2017 commented Sep 3, 2023

Nice work!

@dae-prow dae-prow bot mentioned this pull request Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

@dae-prow dae-prow[bot] dae-prow approved these changes

Assignees

@luochen1990 luochen1990

Labels
feature optimize tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luochen1990 @mzz2017 @piyoki